szehon-ho commented on code in PR #8278:
URL: https://github.com/apache/iceberg/pull/8278#discussion_r1303557007
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -494,7 +522,13 @@ DeleteFileIndex build() {
wrappersBySpecId
.computeIfAbsent(specId, id ->
StructLikeWrapper.forType(spec.partitionType()))
.copyFor(file.partition());
- deleteFilesByPartition.put(Pair.of(specId, wrapper), new
IndexedDeleteFile(spec, file));
+ IndexedDeleteFile indexedFile = new IndexedDeleteFile(spec, file);
+ deleteFilesByPartition.put(Pair.of(specId, wrapper), indexedFile);
+
+ if (!useColumnStatsFiltering) {
Review Comment:
Yea my thought was it translates to:
useColumnStatsWithFiltering = useColumnStatsWithFiltering ||
indexFile.hasLowerAndUpperBound, which shouldn't evaluate the second one in
theory if I understand correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
