aokolnychyi commented on code in PR #8278:
URL: https://github.com/apache/iceberg/pull/8278#discussion_r1303689836
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -604,7 +664,28 @@ private static class DeleteFileGroup {
this.files = files;
}
+ public DeleteFile[] filter(long seq) {
Review Comment:
I think the `Stream` API makes the implementation easier to read in case we
need to iterate through the elements and check if each of them matches. We
would need to try this separately and see how much more complicated it would be
and what kind of benefits we get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
