Fokko commented on code in PR #8408:
URL: https://github.com/apache/iceberg/pull/8408#discussion_r1310783605
##########
python/pyiceberg/transforms.py:
##########
@@ -20,9 +20,8 @@
from abc import ABC, abstractmethod
from enum import IntEnum
from functools import singledispatch
-from typing import Any, Callable, Generic
+from typing import Any, Callable, Generic, Optional, TypeVar
Review Comment:
These changes are great 👍🏻
##########
python/.pre-commit-config.yaml:
##########
@@ -28,52 +28,28 @@ repos:
- id: debug-statements
- id: check-yaml
- id: check-ast
+ - repo: https://github.com/astral-sh/ruff-pre-commit
+ # Ruff version (Used for linting)
+ rev: v0.0.286
+ hooks:
+ - id: ruff
+ args: [ --fix, --exit-non-zero-on-fix ]
- repo: https://github.com/ambv/black
rev: 23.3.0
hooks:
- id: black
- - repo: https://github.com/pre-commit/mirrors-isort
- rev: v5.10.1
- hooks:
- - id: isort
- args: [--settings-path=python/pyproject.toml]
+ args: [--skip-string-normalization]
Review Comment:
Why is this needed?
##########
python/tests/avro/test_file.py:
##########
@@ -21,11 +21,10 @@
from typing import Any
from uuid import UUID
+import pyiceberg.avro.file as avro
Review Comment:
This change is a bit odd
##########
python/pyiceberg/transforms.py:
##########
@@ -20,9 +20,8 @@
from abc import ABC, abstractmethod
from enum import IntEnum
from functools import singledispatch
-from typing import Any, Callable, Generic
+from typing import Any, Callable, Generic, Optional, TypeVar
Review Comment:
These changes are great 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
