MehulBatra commented on code in PR #8408:
URL: https://github.com/apache/iceberg/pull/8408#discussion_r1334534632
##########
python/tests/avro/test_decoder.py:
##########
@@ -24,8 +24,7 @@
from unittest.mock import MagicMock, patch
import pytest
-
-from pyiceberg.avro.decoder import BinaryDecoder, StreamingBinaryDecoder,
new_decoder
+from pyiceberg.avro.decoder import BinaryDecoder, StreamingBinaryDecoder,
new_decoder # type: ignore
Review Comment:
It was throwing Module "pyiceberg.avro.decoder" has no attribute
"new_decoder" while running mypy check in commit hook hence added
# type: ignore comment to tell mypy to ignore this error
##########
python/tests/avro/test_decoder.py:
##########
@@ -24,8 +24,7 @@
from unittest.mock import MagicMock, patch
import pytest
-
-from pyiceberg.avro.decoder import BinaryDecoder, StreamingBinaryDecoder,
new_decoder
+from pyiceberg.avro.decoder import BinaryDecoder, StreamingBinaryDecoder,
new_decoder # type: ignore
Review Comment:
It was throwing Module "pyiceberg.avro.decoder" has no attribute
"new_decoder" while running mypy check in commit hook hence added
# type: ignore comment to tell mypy to ignore this error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
