aokolnychyi commented on code in PR #8383:
URL: https://github.com/apache/iceberg/pull/8383#discussion_r1310789740
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestUpdate.java:
##########
@@ -687,6 +696,13 @@ public synchronized void testUpdateWithSnapshotIsolation()
throws InterruptedException, ExecutionException {
// cannot run tests with concurrency for Hadoop tables without atomic
renames
Assume.assumeFalse(catalogName.equalsIgnoreCase("testhadoop"));
+ // if caching is off, the table is eagerly refreshed during runtime
filtering
+ // this can cause a validation exception as concurrent changes would be
visible
Review Comment:
I added a common method to check whether caching is enabled, but I feel the
comment must be in the test itself for better visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
