aokolnychyi commented on code in PR #8383:
URL: https://github.com/apache/iceberg/pull/8383#discussion_r1310790620
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -948,6 +950,13 @@ public void testDeleteThatRequiresGroupingBeforeWrite()
throws NoSuchTableExcept
public synchronized void testDeleteWithSerializableIsolation() throws
InterruptedException {
// cannot run tests with concurrency for Hadoop tables without atomic
renames
Assume.assumeFalse(catalogName.equalsIgnoreCase("testhadoop"));
+ // if caching is off, the table is eagerly refreshed during runtime
filtering
+ // this can cause a validation exception as concurrent changes would be
visible
+ Assume.assumeTrue(
+ PropertyUtil.propertyAsBoolean(
+ catalogConfig,
+ CatalogProperties.CACHE_ENABLED,
+ CatalogProperties.CACHE_ENABLED_DEFAULT));
Review Comment:
We have to use the actual default value cause we are simply checking if it
is enabled. If we later change the default value, this test should not be
affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
