stevenzwu edited a comment on pull request #856:
URL: https://github.com/apache/incubator-iceberg/pull/856#issuecomment-624766145
@waterlx I would +1 on your proposal of some serializable table interface.
I understand @rdblue argument on not making `Table` interface serializable.
We defined a holder interface that holds the serializable
components/fields/properties from the `Table` interface in our internal PoC
implementation of Flink Iceberg source. However, I don't like the interface
name `TableProperties` as it can easily get confused with the table properties
concept in Iceberg.
```
import lombok.Value;
@Value
public class TableProperties implements Serializable {
private final Schema schema;
private final FileIO fileIO;
private final EncryptionManager encryptionManager;
public TableProperties(Table table) {
this.schema = table.schema();
this.fileIO = table.io();
this.encryptionManager = table.encryption();
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
