waterlx edited a comment on pull request #856: URL: https://github.com/apache/incubator-iceberg/pull/856#issuecomment-624800409
@stevenzwu @JingsongLi Really appreciate your effort to review this PR. I am working on the comments you provided. Meanwhile, our team are focusing on verifying/testing the sink and I am in process of uploading the bug fixes/enhancements into this PR one after another. **Progress update:** The comments by @rdblue @openinx and @jerryshao regarding the initial version of this PR have been almost all addressed. Begin to work on the following items: - Addressing the comments added recnetly by @stevenzwu and @JingsongLi - Testing and bug fixing - Adding UT - Polishing the code and working on check-style issues The PR is being updated and always a workable version (against the master branch) with functions verified. So if you are interested, feel free to download the PR and get it compiled with master branch. [This design doc](https://docs.google.com/document/d/19M-sP6FlTVm7BV7MM4Om1n_MVo1xCy7GyDl_9ZAjVNQ/edit) includes the sample Java code to give it a try 8-) Drop me a mail or add any comments if it does not work. @jerryshao @chenjunjiedada @openinx @aokolnychyi @ @bowenli86 @stevenzwu @JingsongLi @rdblue FYI ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
