ChaladiMohanVamsi commented on code in PR #8533:
URL: https://github.com/apache/iceberg/pull/8533#discussion_r1322901721
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -524,7 +528,11 @@ public Map<String, String> loadNamespaceMetadata(Namespace
namespace)
@Override
public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyException {
- namespaceExists(namespace);
+ // check if namespace exists
+ if (!namespaceExists(namespace)) {
+ LOG.error("Cannot drop namespace {} because it does not exist.",
namespace);
Review Comment:
Followed the similar pattern of logging from dropTable where we log the
error in case `EntityNotFoundException` and return false. I agree that it is
redundant, will go ahead and remove the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
