ChaladiMohanVamsi commented on code in PR #8533:
URL: https://github.com/apache/iceberg/pull/8533#discussion_r1327961729
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -286,8 +286,12 @@ protected String defaultWarehouseLocation(TableIdentifier
tableIdentifier) {
}
@Override
- public List<TableIdentifier> listTables(Namespace namespace) {
- namespaceExists(namespace);
+ public List<TableIdentifier> listTables(Namespace namespace) throws
NoSuchNamespaceException {
Review Comment:
Should we throw NoSuchNamespaceException incase of empty namespace because
Glue doesn't support tables with-out a database or Should we return empty
tables list considering empty namespace as a valid root namespace?
The behaviour in `listNamespaces(Namespace namespace)` returns all the glue
databases in case of empty namespace, this may mean that empty namespace is a
valid root namespace.
Note: empty namespaces implies namespace.isEmpty() is true in the context of
nested namespaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
