aokolnychyi commented on code in PR #8571:
URL: https://github.com/apache/iceberg/pull/8571#discussion_r1328956734


##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestStoragePartitionedJoinsInRowLevelOperations.java:
##########
@@ -134,11 +134,16 @@ private void checkDelete(RowLevelOperationMode mode) {
           SparkPlan plan =
               executeAndKeepPlan(
                   "DELETE FROM %s t WHERE "
-                      + "EXISTS (SELECT 1 FROM %s s WHERE t.id = s.id AND 
t.dep = s.dep) AND "
-                      + "dep = 'hr'",

Review Comment:
   We used to have a filter `dep = 'hr`. The optimizer got smarter and infers 
an extra filter for the other table and removes `t.dep = s.dep` from the join 
condition. The last step breaks SPJ as `dep` is a partition column. There is no 
partition columns in the join condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to