aokolnychyi commented on code in PR #8571:
URL: https://github.com/apache/iceberg/pull/8571#discussion_r1329191114
##########
spark/v3.5/spark-extensions/src/jmh/java/org/apache/iceberg/spark/MergeCardinalityCheckBenchmark.java:
##########
@@ -161,6 +161,7 @@ private void setupSpark() {
.config("spark.sql.catalog.spark_catalog.type", "hadoop")
.config("spark.sql.catalog.spark_catalog.warehouse",
newWarehouseDir())
.config(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED().key(), "false")
+
.config(SQLConf.RUNTIME_ROW_LEVEL_OPERATION_GROUP_FILTER_ENABLED().key(),
"false")
Review Comment:
The benchmark verifies the runtime filtering is disabled, it is controlled
by that property in Spark now.
##########
spark/v3.5/spark-extensions/src/jmh/java/org/apache/iceberg/spark/MergeCardinalityCheckBenchmark.java:
##########
@@ -161,6 +161,7 @@ private void setupSpark() {
.config("spark.sql.catalog.spark_catalog.type", "hadoop")
.config("spark.sql.catalog.spark_catalog.warehouse",
newWarehouseDir())
.config(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED().key(), "false")
+
.config(SQLConf.RUNTIME_ROW_LEVEL_OPERATION_GROUP_FILTER_ENABLED().key(),
"false")
Review Comment:
The benchmark assumes the runtime filtering is disabled, it is controlled by
that property in Spark now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
