aokolnychyi commented on code in PR #8581:
URL: https://github.com/apache/iceberg/pull/8581#discussion_r1329237280
##########
core/src/main/java/org/apache/iceberg/io/FanoutWriter.java:
##########
@@ -36,7 +36,7 @@
* writer may potentially consume substantially more memory compared to {@link
ClusteredWriter}. Use
* this writer only when clustering by spec/partition is not possible (e.g.
streaming).
*/
-abstract class FanoutWriter<T, R> implements PartitioningWriter<T, R> {
+public abstract class FanoutWriter<T, R> implements PartitioningWriter<T, R> {
Review Comment:
It was actually done on purpose as it is a parent class. We expose
`FanoutDataWriter` and related implementations. The same is also true for
`ClusteredWriter`. Is there a particular need to expose this class? Is it
something generic enough to live in the repo itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
