Forkast commented on code in PR #8581:
URL: https://github.com/apache/iceberg/pull/8581#discussion_r1329699423
##########
core/src/main/java/org/apache/iceberg/io/FanoutWriter.java:
##########
@@ -36,7 +36,7 @@
* writer may potentially consume substantially more memory compared to {@link
ClusteredWriter}. Use
* this writer only when clustering by spec/partition is not possible (e.g.
streaming).
*/
-abstract class FanoutWriter<T, R> implements PartitioningWriter<T, R> {
+public abstract class FanoutWriter<T, R> implements PartitioningWriter<T, R> {
Review Comment:
The only difference between `FanoutWriter` and `FanoutDataWriter` is that
the latter enforces the use of `RollingDataWriter` and adds quite a bit of
complexity. I'd argue that both are equally useful and `FanoutWriter` is much
easier to implement and does not enforce things like file name format for
example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
