bryanck commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1330330368
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/TableLoader.java:
##########
@@ -142,4 +160,35 @@ public String toString() {
.toString();
}
}
+
+ class NoOpTableLoader implements TableLoader {
Review Comment:
Yes, both of these are better names, I changed it to `ImmutableTableLoader`.
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -266,6 +268,20 @@ public Builder upsert(boolean enabled) {
return this;
}
+ /**
+ * Sets the table loader used to refresh the table instance in {@link
IcebergStreamWriter}. If
+ * not specified then the default behavior is to not refresh the table,
and the initial table
+ * instance initialized is used for the lifetime of the job.
+ *
+ * @param newTableLoader the table loader to use to refresh the table in
writer subtasks
+ * @return {@link Builder} to connect the iceberg table.
+ */
+ @Experimental
+ public Builder writeTableLoader(TableLoader newTableLoader) {
Review Comment:
I made this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
