bryanck commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1330782463


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/RowDataTaskWriterFactory.java:
##########
@@ -105,10 +104,17 @@ public RowDataTaskWriterFactory(
     }
   }
 
+  void setTable(Table table) {

Review Comment:
   Currently we still want to serialize the original table instance with this 
factory at job start, for its schema and spec, until schema evolution is 
supported.



##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -266,6 +269,20 @@ public Builder upsert(boolean enabled) {
       return this;
     }
 
+    /**
+     * Sets the interval for refreshing the table instance in {@link 
IcebergStreamWriter}. If not
+     * specified then the default behavior is to not refresh the table, and 
the initial table
+     * instance initialized is used for the lifetime of the job.
+     *
+     * @param refreshInterval the interval for refreshing the table in writer 
subtasks
+     * @return {@link Builder} to connect the iceberg table.
+     */
+    @Experimental
+    public Builder tableRefreshInternal(Duration refreshInterval) {

Review Comment:
   whoops, thanks for catching that, I fixed this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to