zeodtr commented on PR #54: URL: https://github.com/apache/iceberg-rust/pull/54#issuecomment-1730927387
@Xuanwo Hi, Maybe it's too early, but I am trying to implement the Catalog API provided with this merge for my Iceberg-related Rust project. But visibility issues prevent me from doing it. For example, NamespaceIdent's field is private, so I cannot create a value of that type. In fact, almost all structs in `catalog.rs` have this visibility issue. Since this merge is a draft, I can assume that `catalog.rs` is incomplete yet. What I want to know is, how will you resolve this visibility issue so that I can pre-modify the source code for the (test-) implementation. I guess there are two ways (BTW, I'm not fluent with Rust): 1. Add public new functions and accessor functions. 2. Make the fields public. I think that for trivial structs like the ones in `catalog.rs` it would be simpler to go to the way 2. What is your plan? Or, maybe I misunderstood something fundamental... Thank you in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
