Xuanwo commented on PR #54: URL: https://github.com/apache/iceberg-rust/pull/54#issuecomment-1730938399
> Since this merge is a draft, I can assume that `catalog.rs` is incomplete yet. Yep, this PR is just to discuss the API with community first. > * Add public new functions and accessor functions. > * Make the fields public. > I think that for trivial structs like the ones in `catalog.rs` it would be simpler to go to the way 2. I believe it is safe to make the fields public as users construct them directly. I will submit a PR for this change to be reviewed in due course. Feel free to join the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
