rdsr commented on a change in pull request #989:
URL: https://github.com/apache/incubator-iceberg/pull/989#discussion_r428299279
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -214,6 +214,7 @@ public static Schema convert(TypeDescription orcSchema) {
"Error in ORC file, children fields and names do not match.");
List<Types.NestedField> icebergFields =
Lists.newArrayListWithExpectedSize(children.size());
+ // TODO how we get field ids from ORC schema
Review comment:
Should we use another PR to fix this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
