rdsr commented on a change in pull request #989:
URL: https://github.com/apache/incubator-iceberg/pull/989#discussion_r429083528
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -308,7 +309,7 @@ private static TypeDescription buildOrcProjection(Integer
fieldId, Type type, bo
orcType = convert(fieldId, type, false);
}
}
-
+ orcType.setAttribute(ICEBERG_ID_ATTRIBUTE, fieldId.toString());
Review comment:
Adding this is actually causing failures
```
org.apache.iceberg.data.orc.TestGenericReadProjection >
testRenamedAddedField FAILED
java.lang.IllegalArgumentException: No conversion of type LONG to self
needed
at
org.apache.orc.impl.ConvertTreeReaderFactory.createAnyIntegerConvertTreeReader(ConvertTreeReaderFactory.java:1671)
at
org.apache.orc.impl.ConvertTreeReaderFactory.createConvertTreeReader(ConvertTreeReaderFactory.java:2124)
at
org.apache.orc.impl.TreeReaderFactory.createTreeReader(TreeReaderFactory.java:2331)
at
org.apache.orc.impl.TreeReaderFactory$StructTreeReader.<init>(TreeReaderFactory.java:1961)
at
org.apache.orc.impl.TreeReaderFactory.createTreeReader(TreeReaderFactory.java:2371)
at
org.apache.orc.impl.RecordReaderImpl.<init>(RecordReaderImpl.java:227)
at org.apache.orc.impl.ReaderImpl.rows(ReaderImpl.java:752)
at
org.apache.iceberg.orc.OrcIterable.newOrcIterator(OrcIterable.java:80)
at org.apache.iceberg.orc.OrcIterable.iterator(OrcIterable.java:65)
at
com.google.common.collect.Iterables.getOnlyElement(Iterables.java:254)
at
org.apache.iceberg.data.orc.TestGenericReadProjection.writeAndRead(TestGenericReadProjection.java:53)
```
And I vaguely remember we fixed a similar bug before in ORC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
