rdblue commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428869358
########## File path: core/src/main/java/org/apache/iceberg/avro/GenericAvroWriter.java ########## @@ -133,4 +141,38 @@ private WriteBuilder() { } } } + + public static class UnionSchemaWriter<V extends Object> implements ValueWriter<V> { Review comment: Files written by Iceberg must always conform to the Iceberg spec. Iceberg tables can allow reading data that is imported, but should _never_ write data that cannot be read by a generic implementation of the Iceberg spec. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org