nastra commented on code in PR #8945:
URL: https://github.com/apache/iceberg/pull/8945#discussion_r1375764386
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java:
##########
@@ -277,12 +275,11 @@ public void
testDowngradeTableToFormatV1ThroughTablePropertyFails() throws Excep
Table table = table("tl");
TableOperations ops = ((BaseTable) table).operations();
Assert.assertEquals("should create table using format v2", 2,
ops.refresh().formatVersion());
-
- AssertHelpers.assertThrowsRootCause(
- "should fail to downgrade to v1",
- IllegalArgumentException.class,
- "Cannot downgrade v2 table to v1",
- () -> sql("ALTER TABLE tl SET('format-version'='1')"));
+ Assertions.assertThatThrownBy(() -> sql("ALTER TABLE tl
SET('format-version'='1')"))
+ .as("should fail to downgrade to v1")
Review Comment:
I think in most cases we don't need `.as()` because the check is
self-explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
