nastra commented on code in PR #8945:
URL: https://github.com/apache/iceberg/pull/8945#discussion_r1375765951
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -197,15 +197,13 @@ public void testJobHashDistributionMode() {
.updateProperties()
.set(TableProperties.WRITE_DISTRIBUTION_MODE,
DistributionMode.HASH.modeName())
.commit();
-
- AssertHelpers.assertThrows(
- "Does not support range distribution-mode now.",
- IllegalArgumentException.class,
- "Flink does not support 'range' write distribution mode now.",
- () -> {
- testWriteRow(null, DistributionMode.RANGE);
- return null;
- });
+ Assertions.assertThatThrownBy(
+ () -> {
+ testWriteRow(null, DistributionMode.RANGE);
+ })
+ .as("Does not support range distribution-mode now.")
Review Comment:
not needed as it's implicit through the expected error msg. The same is true
for most other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
