rdblue opened a new pull request #1099: URL: https://github.com/apache/iceberg/pull/1099
This refactors `ManifestReader` and `DeleteManifestReader` into the same parameterized class, `ManifestReader<DataFile | DeleteFile>`. Using two separate classes didn't match the write side, where there is one `ManifestWriter` that is parameterized, and prevented code paths from supporting both data and delete files. For example, a class to merge manifests should be agnostic to the type of manifest, as long as either data or delete manifests are consistently merged. This commit is also included in #1098 because it is required for those changes. I will rebase that commit this is merged first. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
