danielcweeks commented on a change in pull request #1099:
URL: https://github.com/apache/iceberg/pull/1099#discussion_r437567187
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -235,7 +235,7 @@ private void performRewrite(List<ManifestFile>
currentManifests) {
keptManifests.add(manifest);
} else {
rewrittenManifests.add(manifest);
- try (ManifestReader reader = ManifestFiles.read(manifest,
ops.io(), ops.current().specsById())
+ try (ManifestReader<DataFile> reader =
ManifestFiles.read(manifest, ops.io(), ops.current().specsById())
Review comment:
Does this mean we can only do rewrites if there are no `DeleteFile`'s?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
