rdblue commented on a change in pull request #1098:
URL: https://github.com/apache/iceberg/pull/1098#discussion_r437794479
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -62,73 +41,91 @@
import static
org.apache.iceberg.TableProperties.SNAPSHOT_ID_INHERITANCE_ENABLED_DEFAULT;
abstract class MergingSnapshotProducer<ThisT> extends SnapshotProducer<ThisT> {
- private static final Logger LOG =
LoggerFactory.getLogger(MergingSnapshotProducer.class);
+ private final String tableName;
+ private final TableOperations ops;
+ private final PartitionSpec spec;
+ private final SnapshotSummary.Builder summaryBuilder =
SnapshotSummary.builder();
+ private final ManifestMergeManager<DataFile> mergeManager;
+ private final ManifestFilterManager<DataFile> filterManager;
+ private final boolean snapshotIdInheritanceEnabled;
- private static final Joiner COMMA = Joiner.on(",");
+ private class DataFileFilterManager extends ManifestFilterManager<DataFile> {
Review comment:
I do that in #1105.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
