aokolnychyi commented on a change in pull request #1098:
URL: https://github.com/apache/iceberg/pull/1098#discussion_r438220791
##########
File path:
core/src/test/java/org/apache/iceberg/TestSequenceNumberForV2Table.java
##########
@@ -272,7 +276,7 @@ public void testConcurrentTransaction() {
manifestFile = table.currentSnapshot().allManifests().stream()
.filter(manifest -> manifest.snapshotId() == commitId4)
.collect(Collectors.toList()).get(0);
- validateManifest(manifestFile, seqs(3, 2, 4), ids(commitId3, commitId2,
commitId4), files(FILE_C, FILE_B, FILE_A));
+ validateManifest(manifestFile, seqs(4), ids(commitId4), files(FILE_A),
statuses(Status.DELETED));
Review comment:
Yes, the manifest for commitId4 will not be combined with others and
therefore will only contain `FILE_A`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
