rdblue commented on pull request #1103: URL: https://github.com/apache/iceberg/pull/1103#issuecomment-642173949
Thanks, @cmathiesen and @massdosage! Looks like a good start. I think we need to take a close look at how date/time types are handled because the Iceberg generics use Java 8 classes. I don't think that the object inspectors support those, and the inspector created for timestamp (converted to bigint `TypeInfo`) will definitely not work if it is called for a LocalDateTime or OffsetDateTime. I'd also like to exercise the object inspectors in a test to make sure a record wrapped by IcebergWritable returns the correct types when deserialized and inspected. That would have caught the issue above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
