massdosage commented on a change in pull request #1103: URL: https://github.com/apache/iceberg/pull/1103#discussion_r438659604
########## File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr; + +import java.util.function.Function; +import org.apache.hadoop.conf.Configuration; +import org.apache.iceberg.Schema; +import org.apache.iceberg.SchemaParser; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.expressions.Expression; + +public class InputFormatConfig { Review comment: This is from #933, specifically at https://github.com/apache/iceberg/pull/933/files#diff-0aa47c0ca21b715226d83ae55f4b4671 so we just pulled that class in here "as is" as it was easier. If you'd prefer we can trim this down to just the config needed by the SerDe or we can (temporarily) put the code elsewhere in this PR and then refactor it back into this class when we come back to#933 after this is merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
