rdblue commented on a change in pull request #830:
URL: https://github.com/apache/iceberg/pull/830#discussion_r441012398
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/VectorizedParquetReader.java
##########
@@ -48,11 +49,12 @@
private boolean reuseContainers;
private final boolean caseSensitive;
private final int batchSize;
+ private final NameMapping nameMapping;
public VectorizedParquetReader(
- InputFile input, Schema expectedSchema, ParquetReadOptions options,
- Function<MessageType, VectorizedReader<?>> readerFunc,
- Expression filter, boolean reuseContainers, boolean caseSensitive, int
maxRecordsPerBatch) {
+ InputFile input, Schema expectedSchema, ParquetReadOptions options,
Function<MessageType,
+ VectorizedReader<?>> readerFunc, NameMapping nameMapping, Expression
filter, boolean reuseContainers,
Review comment:
Please don't split types across lines. I think moving
`Function<MessageType` to the previous line should be reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
