rdblue commented on a change in pull request #830:
URL: https://github.com/apache/iceberg/pull/830#discussion_r441027126
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/MessageTypeToType.java
##########
@@ -229,7 +229,7 @@ private void addAlias(String name, int fieldId) {
aliasToId.put(DOT.join(path(name)), fieldId);
}
- protected int nextId() {
+ private int nextId() {
Review comment:
I'd also prefer to revert this change. There may not be a use of it as a
`protected` method any more, but we don't need to change this file and risk git
conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
