rdblue commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r444578082
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java
##########
@@ -284,6 +291,11 @@ public void write(int repetitionLevel, byte[] value) {
}
}
+ public interface StructWriterFactory {
Review comment:
Instead of adding this interface, what about adding
`WriteBuilder.createStructWriter` to do this? That way, the Flink builder could
just inherit from the generic builder and override that one method.
I think that would be cleaner because adding this interface requires also
adding public methods to pass the factory. I'd rather not add those public
methods if we can avoid it by adding a protected method and change the builder
to a protected class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
