openinx commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r445257160
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java
##########
@@ -284,6 +291,11 @@ public void write(int repetitionLevel, byte[] value) {
}
}
+ public interface StructWriterFactory {
Review comment:
Em, I've implemented two versions. the first version provides a
`public` interfaces with protected `StructureWriterFactory` and
`StructReaderFactory`, the second version use the inherit `WriterBuilder` &
`ReaderBuilder` https://github.com/apache/iceberg/pull/1125. For me , seems the
first version looks much more concise. I plan to change to version#1 (with the
`public` interface and `protected` methods ). Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
