jun-he commented on a change in pull request #1139:
URL: https://github.com/apache/iceberg/pull/1139#discussion_r446807520
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -116,7 +116,18 @@ private boolean eval(MessageType fileSchema, BlockMetaData
rowGroup,
}
}
- return ExpressionVisitors.visitEvaluator(expr, this);
+ try {
+ return ExpressionVisitors.visitEvaluator(expr, this);
+
+ } finally {
+ // allow temporary state to be collected because this is in a
thread-local
Review comment:
As it resets all instance variables, curious what if directly creating a
new `EvalVisitor` object instead of using ThreadLocal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
