jun-he commented on a change in pull request #1139:
URL: https://github.com/apache/iceberg/pull/1139#discussion_r447422849
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -116,7 +116,18 @@ private boolean eval(MessageType fileSchema, BlockMetaData
rowGroup,
}
}
- return ExpressionVisitors.visitEvaluator(expr, this);
+ try {
+ return ExpressionVisitors.visitEvaluator(expr, this);
+
+ } finally {
+ // allow temporary state to be collected because this is in a
thread-local
Review comment:
I think it makes sense to fix it for now with the current way, which has
the minimal side effect.
Additionally, I think we might not save much in case there is a new thread
for each task. Also the thread local itself might add additional cost as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
