rdblue commented on a change in pull request #922:
URL: https://github.com/apache/iceberg/pull/922#discussion_r449922403
##########
File path: core/src/test/java/org/apache/iceberg/TestPartitionSpecParser.java
##########
@@ -19,16 +19,20 @@
package org.apache.iceberg;
+import org.apache.iceberg.types.Types;
import org.junit.Assert;
import org.junit.Test;
-public class TestPartitionSpecParser extends TableTestBase {
- public TestPartitionSpecParser() {
- super(1);
- }
+import static org.apache.iceberg.types.Types.NestedField.required;
+
+public class TestPartitionSpecParser {
+ private static final Schema SCHEMA = new Schema(
+ required(1, "id", Types.IntegerType.get()),
+ required(2, "data", Types.StringType.get())
+ );
@Test
- public void testToJsonForV1Table() {
+ public void testToJson() {
Review comment:
Instead of changing existing test cases, let's add new test cases for
the case you want to exercise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
