pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1637636105
########## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TagBasedLockFactory.java: ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.util.Map; +import org.apache.flink.annotation.Internal; +import org.apache.iceberg.ManageSnapshots; +import org.apache.iceberg.SnapshotRef; +import org.apache.iceberg.Table; +import org.apache.iceberg.flink.TableLoader; +import org.apache.iceberg.util.Tasks; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Iceberg table {@link ManageSnapshots#createTag(String, long)}/{@link + * ManageSnapshots#removeTag(String)} based lock implementation for {@link TriggerLockFactory}. + */ +@Internal +public class TagBasedLockFactory implements TriggerLockFactory { Review Comment: > tag-based locks also have higher overhead (metadata JSON file rewrite) compared to other standard solution like SQL database Agreed. That's why the interface. We can provide other implementations later. Maybe even a REST catalog based solution, or HMS based solution above the JDBC based one. I envision this as a first solution without additional external depenency which could be used with any existing Iceberg implementation. > also how are we going to deal with orphaned locks, where unlock didn't happen? Job start with the cleanup will always delete the lock, and the job restart logic will fix any remaining locks. Maybe we can add a lock timeout function too, so if we wait more than 1 day (configurable) for the lock then we just assume that it's orphaned, and then we reuse the same cleanup logic that used during the restart to clear the orphaned lock. I think this decision could be postponed until we see if this is a frequent issue, and simple monitoring and restart is not enough to solve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
