pvary commented on code in PR #10484: URL: https://github.com/apache/iceberg/pull/10484#discussion_r1637686857
########## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/Trigger.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.util.Objects; +import org.apache.flink.annotation.Internal; +import org.apache.iceberg.SerializableTable; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; + +@Internal +class Trigger { + private final long timestamp; + private final SerializableTable table; + private final Integer taskId; + private final boolean isCleanUp; + + private Trigger(long timestamp, SerializableTable table, Integer taskId, boolean isCleanUp) { + this.timestamp = timestamp; + this.table = table; + this.taskId = taskId; Review Comment: > in the 2nd option, why does watermark generator needs to be n instances? Here is how lock handling will go: - `TriggerManager` creates a lock - We generate a Watermark which travels through all of the Maintenance Task streams - We join the streams at the end and remove the lock when the Watermark arrives from all of the substreams. We need to join the Maintenance Task streams, so when cleaning the locks on recovery then the recovery trigger watermark will signal that the previously started Maintenance Tasks are finished (whichever one was running). In the 2nd option we have a sideoutput for every Maintenance Task. We need to put the same watermark to them, so the lock cleaner will receive a watermark from each of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
