rdblue commented on a change in pull request #1228:
URL: https://github.com/apache/iceberg/pull/1228#discussion_r458928613
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -386,7 +386,7 @@ private static SparkPartition
toSparkPartition(CatalogTablePartition partition,
Preconditions.checkArgument(serde.nonEmpty() ||
table.provider().nonEmpty(),
"Partition format should be defined");
- String uri = String.valueOf(locationUri.get());
+ URI uri = locationUri.get();
Review comment:
Okay, it sounds like we can keep this fix scoped to just these classes
where we need to preserve the original URI instead of modifying it. That's a
good rule for us to follow: if we have a URI, then use the URI constructor. If
we have a String, use the String constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
