RussellSpitzer commented on a change in pull request #1228:
URL: https://github.com/apache/iceberg/pull/1228#discussion_r458933173



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -386,7 +386,7 @@ private static SparkPartition 
toSparkPartition(CatalogTablePartition partition,
     Preconditions.checkArgument(serde.nonEmpty() || 
table.provider().nonEmpty(),
         "Partition format should be defined");
 
-    String uri = String.valueOf(locationUri.get());
+    URI uri = locationUri.get();

Review comment:
       Works at least for my little example
   
   `scala> val uri = new URI("file:///has%20spaces")
   uri: java.net.URI = file:///has%20spaces
   
   scala> new Path(uri).toString
   res0: String = file:/has spaces
   
   scala> new Path(new Path(uri).toString)
   res1: org.apache.hadoop.fs.Path = file:/has spaces`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to