pvary commented on code in PR #10484:
URL: https://github.com/apache/iceberg/pull/10484#discussion_r1643986681
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -397,6 +398,25 @@ private String errorMsg(String operation) {
return String.format("Operation %s is not supported after the table is
serialized", operation);
}
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+
+ SerializableTable other = (SerializableTable) o;
+ return Objects.equals(metadataFileLocation, other.metadataFileLocation);
+ }
+
+ @Override
+ public int hashCode() {
+ return metadataFileLocation.hashCode();
Review Comment:
Removed, added a utility method for comparison as it is used only in the
tests ATM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
