rdblue commented on a change in pull request #1228:
URL: https://github.com/apache/iceberg/pull/1228#discussion_r458991231
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -105,6 +105,20 @@
private SparkTableUtil() {
}
+ /**
+ * From Apache Spark
+ *
+ * Convert URI to String.
+ * Since URI.toString does not decode the uri, e.g. change '%25' to '%'.
+ * Here we create a hadoop Path with the given URI, and rely on Path.toString
+ * to decode the uri
+ * @param uri the URI of the path
+ * @return the String of the path
+ */
+ public static String uriToString(URI uri) {
Review comment:
If this is going to be public, I'd rather find a better place than in
`SparkTableUtil`, like `org.apache.iceberg.hadoop.Util`. I'm also fine with
this being a private method here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
