rdblue commented on a change in pull request #1221:
URL: https://github.com/apache/iceberg/pull/1221#discussion_r459166483
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestSparkSchema.java
##########
@@ -46,12 +46,12 @@
public abstract class TestSparkSchema {
- private static final Configuration CONF = new Configuration();
- private static final Schema SCHEMA = new Schema(
+ protected static final Configuration CONF = new Configuration();
+ protected static final Schema SCHEMA = new Schema(
optional(1, "id", Types.IntegerType.get()),
optional(2, "data", Types.StringType.get())
);
- private static SparkSession spark = null;
+ protected static SparkSession spark = null;
Review comment:
This doesn't need to change since the tests should be in the `spark`
module instead of in a subclass of `TestSparkSchema`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
