rdblue commented on a change in pull request #1221:
URL: https://github.com/apache/iceberg/pull/1221#discussion_r459168106
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -276,6 +277,13 @@ public void pruneColumns(StructType newRequestedSchema) {
@Override
public Statistics estimateStatistics() {
+ if (filterExpressions == null || filterExpressions ==
Expressions.alwaysTrue()) {
+ LOG.debug("using table metadata to estimate table statistics");
Review comment:
Minor: I don't see much value in having this debug statement.
If you were trying to debug `estimateStatistics`, I think you'd want to have
a message for every call, and you would want it to show the expression as well
as the resulting estimate. I think Spark already has those logs, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
