amogh-jahagirdar commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2211066525
Hey everyone, sorry for the delay just want to make sure we're following the standard improvement proposal process here: 1.) https://iceberg.apache.org/contribute/#what-is-an-improvement-proposal 2.) https://iceberg.apache.org/contribute/#how-are-proposals-adopted Going through the above 2 guidelines, this should go through a formal vote on the mailing list before merging since it's a spec change. Also, even though this change can be considered trivial because Puffin is relatively new, Puffin V1 was still technically voted on and agreed upon in the past. Especially since this is an optional->required change, it'd probably be best if this change was made as part of a Puffin V2. In hindsight, I should've thought of this, I mainly thought since it was trivial/not as adopted it'd be OK but we probably don't want to have these 1 off cases in our decision making in the community since then it becomes ambiguous when it's acceptable or not. What this would mean for the original PR https://github.com/apache/iceberg/pull/10288/ is that it should respect the spec as is it is today and have some fallback to read the sketch in case the NDV property does not exist. I'm going to send these thoughts on the mailing list discuss thread cc @findepi @karuppayya @singhpk234 @szehon-ho @Fokko @ajantha-bhat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
