amogh-jahagirdar commented on PR #10549: URL: https://github.com/apache/iceberg/pull/10549#issuecomment-2211248500
@findepi I think I largely agree with you that a Puffin V2 is probably too broad for this since we're not even changing the metadata; we can granularly update the theta sketch definition, since one of the goals for Puffin was to evolve blobs independently without having to change the Puffin spec. > And thus, Iceberg may decide that whenever apache-datasketches-theta-v1 blob type is used in Puffin, the blob can be, should be or must be associated with ndv property. I don't think I fully agree with this in that, I don't think we can just directly change a blob type without going through an upgrade of the blob type. The spec has defined this blob type `apache-datasketches-theta-v1`, and I consider it as an official type since it's defined with what needs to be stored. I think a `apache-datasketches-theta-v2` is more appropriate since we're making an optional field required after the blob type was already voted upon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
