ajantha-bhat commented on code in PR #10643:
URL: https://github.com/apache/iceberg/pull/10643#discussion_r1669739401
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -70,4 +70,10 @@ default RewritePositionDeleteFiles
rewritePositionDeletes(Table table) {
throw new UnsupportedOperationException(
this.getClass().getName() + " does not implement
rewritePositionDeletes");
}
+
+ /** Instantiates an action to remove expired files. */
+ default RemoveExpiredFiles removeExpiredFiles(Table table) {
Review Comment:
a) Let me go through the `table copying` PR and the changes looks like it is
specifically needed only for table copy.
b) Can't the existing remove orphan files clean those left over files after
table copy?
c) `RemoveExpiredFiles`, I definitely want the naming to be different. It is
already confusing. Maybe as `RemoveTableCopyOrphanFiles`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
