RussellSpitzer commented on code in PR #10643:
URL: https://github.com/apache/iceberg/pull/10643#discussion_r1678381082
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -70,4 +70,10 @@ default RewritePositionDeleteFiles
rewritePositionDeletes(Table table) {
throw new UnsupportedOperationException(
this.getClass().getName() + " does not implement
rewritePositionDeletes");
}
+
+ /** Instantiates an action to remove expired files. */
+ default RemoveExpiredFiles removeExpiredFiles(Table table) {
Review Comment:
I think the name and purpose here are a little confusing for a public API. I
would agree with @ajantha-bhat that we should consider keeping this a private
part of the copy table action. If we are going to make it public maybe it
should be a sub-function of that action, rather than top level api here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
