nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1669835108


##########
build.gradle:
##########
@@ -81,6 +81,7 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
                               "--add-opens", 
"java.base/jdk.internal.reflect=ALL-UNNAMED",
                               "--add-opens", "java.sql/java.sql=ALL-UNNAMED",
                               "--add-opens", 
"java.base/sun.util.calendar=ALL-UNNAMED",
+                              "--add-opens", 
"java.base/sun.net.util=ALL-UNNAMED",

Review Comment:
   CI also runs the tests with JDK17 so I'm surprised that this would fail with 
JDK17. Could you please double-check whether tests pass with JDk17 for you 
without this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to