nastra commented on code in PR #10657:
URL: https://github.com/apache/iceberg/pull/10657#discussion_r1669847090


##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -521,30 +508,7 @@ public void testAsOfTimeOlderThanFirstSnapshot() {
             "Cannot find a snapshot older than " + 
DateTimeUtil.formatTimestampMillis(timestamp));
   }
 
-  private DataFile writeFile(String location, String filename, List<Record> 
records)

Review Comment:
   can you please move these methods back as that doesn't seem necessary to 
move them around



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to